Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression in streams with PTS wrapping prior to DTS #2929

Merged
merged 1 commit into from Jul 30, 2020
Merged

Fix regression in streams with PTS wrapping prior to DTS #2929

merged 1 commit into from Jul 30, 2020

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Jul 29, 2020 •
edited

This PR will...

Compare set sort and shift flags after PTSNormalize is applied.

Why is this Pull Request needed?

  • Fixes false positive on the sortSamples flag when the last sample's dts was normalized but the current was not.
  • Fixes false positive on the ptsDtsShift flag when sample.pts is less than sample.dts before PTSNormalize is applied.

Resolves issues:

Relates to #1796

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 0.14.7 milestone Jul 29, 2020
@robwalch robwalch requested a review from itsjamie July 29, 2020 22:16
@robwalch robwalch merged commit 20cd617 into master Jul 30, 2020
@robwalch robwalch deleted the bugfix/handle-wrapped-pts-before-dts branch July 30, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsjamie itsjamie itsjamie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.14.7
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@robwalch @itsjamie