Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stream duration update regression with discontinuities and misaligned AV #2932

Merged

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Jul 30, 2020

This PR will...

Do not use shorter track duration when updating fragment timing at a discontinuity.

Why is this Pull Request needed?

The first of audio and video tracks to end is used to determine the start of the next segment - but this should only be done when segments are contiguous and we expect the same track to start sooner. In the case of a discontinuity, we want the next segment to start after both tracks in the previous segment have ended.

In earlier releases and in Safari, this stream has a duration of ~40 seconds. These changes restore that duration which was being cut short by always using minEndPTS in the changes below.

http://playertest.longtailvideo.com/adaptive/boxee/playlist.m3u8

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 0.14.7 milestone Jul 30, 2020
@robwalch robwalch requested a review from itsjamie July 30, 2020 17:59
@robwalch robwalch merged commit 1b2cd57 into master Jul 30, 2020
@robwalch robwalch deleted the bugfix/do-not-use-shorter-track-duration-at-discontinuity branch July 30, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants