Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require min cue duration of 0.25 #2951

Merged

Conversation

jnatalzia
Copy link
Contributor

@jnatalzia jnatalzia commented Aug 4, 2020

This PR will...

Update the id3 parser to ensure cues have a duration of at least 0.25s

Why is this Pull Request needed?

We are seeing missing TextTrack change events in cases where the cue exists at the end of a segment due to the previous 0.0001 adjustment not providing a long enough duration to fire when the playhead plays over the cue.

Are there any points in the code the reviewer needs to double check?

All of it, I'm new

Resolves issues:

JW8-11282

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 0.15.0 milestone Aug 4, 2020
@robwalch robwalch merged commit 0476198 into video-dev:master Aug 4, 2020
@robwalch robwalch modified the milestones: 0.15.0, 0.14.8 Aug 7, 2020
@bxthomas
Copy link

Ugh, this change broke our use case for HLS.js. We use ID3 tags to carry frame level metadata. The ID3 tag needs to have the same duration as a video sample.

@robwalch
Copy link
Collaborator

robwalch commented Aug 10, 2020

Hi @bxthomas,

Please fill out the Bug Report Template to report regressions caused by this change. As part of the issue, please include:

  • Test stream/page (if possible)
  • Steps to reproduce
  • Expected behavior
  • Actual behavior

I'd be interested to know in the write up, how the cue durations affect your app, and how you use them in a timed context. Does each frame get a cue, or only certain ones? Do you use activeCues and if so how do account for time events not being tied to frame updates? Also knowing what the minimum cue or frame duration is would be useful. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants