Only apply minimum ID3 cue duration when cue has none #2964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Only apply minimum ID3 cue duration when cue does not have a valid duration.
Why is this Pull Request needed?
ID3 cues found on the last sample of an ID3 track or cues in tracks with out-of-order PTS will have an end time that is equal or less than their start time, which is not valid.
This fixes a regression introduced in v0.14.8 with #2951 where we applied a minimum duration 0.25s to all metadata cues, to ensure change events always fire, without considering the need to maintain the duration of cues intended to provide data relative to video frames (where the duration is more likely to be ~0.008-0.04s).
Resolves issues:
#2963
Checklist