Always parse ID3 tags if type is present on the ID3 Frame #3284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nebnitt
commented
Dec 8, 2020
zetagame
previously approved these changes
Dec 8, 2020
robwalch
requested changes
Dec 8, 2020
robwalch
requested changes
Dec 8, 2020
robwalch
approved these changes
Dec 8, 2020
robwalch
added a commit
that referenced
this pull request
Dec 8, 2020
Always parse ID3 tags if type is present on the ID3 Frame
robwalch
pushed a commit
that referenced
this pull request
Dec 8, 2020
* patch/v0.14.x: Merge pull request #3284 from video-dev/update-id3-parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
This PR updates our ID3 tag parsing to ensure that we always parse and surface the ID3 tags as long as the
typeis present on the frame.Why is this Pull Request needed?
Certain users, such as Yospace, have custom ID3 tags, like
YMID, that were previously being dropped in the parsing step as they did not follow any of the expected patterns.For an example, see the following test stream: http://playertest.longtailvideo.com/adaptive/yospace-id3/index.m3u8
Are there any points in the code the reviewer needs to double check?
I don't believe so, but as this is my first contribution here, possibly!
Resolves issues:
Checklist