Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PIPELINE_ERROR_DECODE error streams with AAC segments #3703

Merged
merged 1 commit into from Mar 31, 2021

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Mar 30, 2021

This PR will...

Fix ADTS canParse (last sample), typos, and logging.

Why is this Pull Request needed?

Fixes PIPELINE_ERROR_DECODE errors in certain streams with acc file segments.

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.0.0 milestone Mar 30, 2021
@robwalch robwalch added this to Top priorities in Release Planning and Backlog via automation Mar 30, 2021
@robwalch robwalch moved this from Top priorities to v1.0.0 in Release Planning and Backlog Mar 30, 2021
Fixes PIPELINE_ERROR_DECODE errors in certain streams with acc file segments
@robwalch robwalch force-pushed the bugfix/aac-pipeline-error-decode branch from 3b96812 to b9a1a3f Compare March 31, 2021 04:50
@robwalch robwalch changed the title Fix ADTS canParse (last sample) Fix PIPELINE_ERROR_DECODE error streams with AAC segments Mar 31, 2021
@robwalch robwalch merged commit b187a6c into master Mar 31, 2021
@robwalch robwalch deleted the bugfix/aac-pipeline-error-decode branch March 31, 2021 14:15
@ghost
Copy link

ghost commented Apr 2, 2021

Hi there.
This stream https://bitdash-a.akamaihd.net/content/sintel/hls/playlist.m3u8 still show error PIPELINE_ERROR_DECODE.
Hls.js v1.0.0

"The video playback was aborted due to a corruption problem or because the video used features your browser did not support - PIPELINE_ERROR_DECODE: Failed to send audio packet for decoding: {timestamp=2000 duration=21333 size=783 is_key_frame=1 encrypted=0}"

@robwalch
Copy link
Collaborator Author

robwalch commented Apr 2, 2021

Hi @sergiyshutov,

Same error, different (unknown) cause. Please file a new bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant