fix: stopLoad() after destroy() becomes no-op, startLoad() after destroy() throws nicer error message. #3710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roy() throws nicer error message.
robwalch
requested changes
Apr 5, 2021
src/hls.ts
Outdated
| @@ -284,8 +284,7 @@ export default class Hls implements HlsEventEmitter { | |||
| this.url = null; | |||
| if (this.networkControllers) { | |||
| this.networkControllers.forEach((component) => component.destroy()); | |||
| // @ts-ignore | |||
| this.networkControllers = null; | |||
| this.networkControllers = undefined; | |||
There was a problem hiding this comment.
What if we just did this?
Suggested change
| this.networkControllers = undefined; | |
| this.networkControllers.length = 0; |
There was a problem hiding this comment.
That's a much simpler fix. :) I made the same change to coreComponents below, too.
jwalton
added a commit
to jwalton/hls.js
that referenced
this pull request
Apr 6, 2021
…n feedback from review. re: video-dev#3710
…n feedback from review. re: video-dev#3710
jwalton
force-pushed
the
stop-load-after-destroy
branch
from
0532e8b
to
cd070b5
Compare
robwalch
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will make error messages nicer when you call stopLoad() or startLoad() after calling destroy.
Why is this Pull Request needed?
This is a super minor fix. I was getting the very unhelpful error:
TypeError: Cannot read property 'forEach' of null. It turns out I was callingstopLoad()after callingdestroy(), and was running into:but
this.networkControllershad been set tonullin thedestroy()function.So this change:
networkControllersis defined as an array or undefined.stopLoad()whennetworkControllersis undefined (this is a no-op now).startLoad()on destroyed instance of hls" when you callstartLoad()after callingdestroy().Are there any points in the code the reviewer needs to double check?
No
Resolves issues:
None.
Checklist