Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use track name over track index, fixes unordered track group switching #3731

Merged
merged 1 commit into from Apr 8, 2021

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Apr 6, 2021

This PR will...

  • Use track name over track index, fixes unordered track group switching
  • Adds 'name' property to audio and subtitle track switching events
  • Sets selectDefaultTrack to false so that track name matching works when indexes are not aligned / there's a default track and no manual track selection to disable first

Why is this Pull Request needed?

Fixes an exception when switching levels that use audio groups with inconsistent track order (and a default track)

Resolves issues:

Resolves #3729

Checklist

  • changes have been done against master branch, and PR does not conflict

Adds 'name' property to audio and subtitle track switching events
Resolves #3729
@robwalch robwalch added this to the 1.1.0 milestone Apr 7, 2021
@robwalch robwalch added this to Top priorities in Release Planning and Backlog via automation Apr 7, 2021
@robwalch robwalch modified the milestones: 1.1.0, 1.0.1 Apr 7, 2021
@robwalch robwalch merged commit 4cb6fb0 into master Apr 8, 2021
@robwalch robwalch deleted the bugfix/track-switch-name-over-order branch April 8, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Release Planning and Backlog
  
Top priorities
Development

Successfully merging this pull request may close these issues.

Playback failure when order of audio tracks within each group is inconsistent in manifest.
1 participant