Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor startPosition from config/startLoad with live streams #3740

Merged

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Apr 7, 2021

This PR will...

  1. Honor config.startPosition and hls.startLoad(startPosition) with live streams
  2. Do not sync with the live edge when playback is within sliding window and liveMaxLatencyDuration or liveMaxLatencyDurationCount

Why is this Pull Request needed?

  1. startPosition was ignored when selecting the first fragment to load in a live stream so that we could use getInitialLiveFragment. This is in part because we could not tell if startPosition was specified by the user or set internally. By not setting it internally until after getInitialLiveFragment for default behavior when not set, we can honor the user's intent when it is.
  2. Fixes a regression where synchronizeToLiveEdge would seek to the live sync position when underbuffered (on start) even though playback was within an acceptable range.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Fixes #3736

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.0.1 milestone Apr 7, 2021
Do not sync with live edge when inside sliding window and liveMaxLatencyDuration
Fixes #3736
@robwalch robwalch force-pushed the bugfix/start-position-overrides-initial-live-fragment branch from 8df2c6e to 9ff3ab8 Compare April 7, 2021 22:50
@robwalch robwalch merged commit a8fad5a into master Apr 8, 2021
@robwalch robwalch deleted the bugfix/start-position-overrides-initial-live-fragment branch April 8, 2021 22:27
@robwalch robwalch linked an issue Apr 13, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Understanding Live Playlist Re-Sync Behavior startPosition is ignored / slides back to live sync point
1 participant