Fix fmp4 segmented audio group switching #3748
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
groupId
toAudioTrackSwitchingData
andSubtitleTrackSwitchData
(just addedname
recently and in light of this issue,groupId
is also something you'd want to know about an upcoming track change)Why is this Pull Request needed?
The transmuxer doesn't see audio groups so tracks in different groups with the same index appear as contiguous segments. Resetting the transmuxer on audio track update deals with this type of discontinuity resetting where audio is appended when the active group is changed.
hls.js/src/demux/transmuxer-interface.ts
Lines 159 to 163 in 072ef4b
Are there any points in the code the reviewer needs to double check?
I considered adding groupId or original track id indexes (across groups) to the transmux pipeline but that would involve adding them to Fragment objects, ChunkMeta, multiple playlist/track types, as well multiple event types. This change has a much smaller footprint, making it a safer patch.
Resolves issues:
Resolves #3741
Checklist