Fix MEDIA_ATTACHED > loadSource recursive calls
#3754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
…e URL has changed, and source buffer types are set Resolves #3732
robwalch
force-pushed
the
bugfix/load-source-in-attach-media-and-reattach
branch
from
99f044e
to
c40420f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Do not detach and reattach media in
loadSourcewhen in an hls.js event loop.When
loadSourceis called, only detach and reattach media if URL has changed, and source buffer types are set.Why is this Pull Request needed?
Prevents recursive calls when
loadSourceis called in an event handler such asMEDIA_ATTACHED, or any prior toBUFFER_CODECS. This is where theBufferController'sSourceBufferconfiguration is set. Loading a new stream prior to that can be performed without reattaching. After that, reattaching is necessary to reset the source buffers.Resolves issues:
Resolves #3732
Checklist