Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Video Glitches with Fetch Loader #3755

Merged
merged 3 commits into from Apr 13, 2021

Conversation

softworkz
Copy link
Contributor

Fixes #3747

Copy link
Collaborator

@robwalch robwalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to have to figure out how to fix the tsdemuxer's progressive behavior without forcing non-progressive leave samples that are later flushed resulting in additional appends.

src/demux/tsdemuxer.ts Show resolved Hide resolved
src/utils/fetch-loader.ts Show resolved Hide resolved
@robwalch robwalch added this to Top priorities in Release Planning and Backlog via automation Apr 12, 2021
@robwalch robwalch added this to the 1.0.1 milestone Apr 12, 2021
@softworkz
Copy link
Contributor Author

softworkz commented Apr 13, 2021

We're going to have to figure out how to fix the tsdemuxer's progressive behavior without forcing non-progressive leave samples that are later flushed resulting in additional appends.

I will make the suggested change and update this PR, so we should be fine for the non-progressive side.


UPDATE: I have removed my original reply and created a separate issue for it: #3767
(appears to be unrelated)

@softworkz
Copy link
Contributor Author

Just pushed another commit

@robwalch robwalch merged commit b14d783 into video-dev:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Release Planning and Backlog
  
Top priorities
Development

Successfully merging this pull request may close these issues.

Video Glitches with Fetch Loader
2 participants