Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1 regression: DEFAULT flag for subtitles / captions no-longer respected #3780

Closed
4 tasks done
philcluff opened this issue Apr 15, 2021 · 0 comments · Fixed by #3781
Closed
4 tasks done

V1 regression: DEFAULT flag for subtitles / captions no-longer respected #3780

philcluff opened this issue Apr 15, 2021 · 0 comments · Fixed by #3781
Labels
Bug Regression A bug introduced in a recent release
Projects
Release Planning and Backlog
Milestone
1.0.2

Comments

@philcluff
Copy link
Collaborator

philcluff commented Apr 15, 2021 •
edited

What version of Hls.js are you using?

1.0.1 - https://philcluff.co.uk/players/hls-js.html

What browser and OS (including versions) are you using?

Chrome Beta - 90.0.4430.70 on MacOS

Test stream:

https://stream.mux.com/wTZ023wl001qXWS7l7YM01ACCXXFl00UXWxH.m3u8?default_subtitles_lang=en

Configuration:

Default configuration

Checklist

  • The issue observed is not already reported by searching on Github under https://github.com/video-dev/hls.js/issues
  • The issue occurs in the stable client on https://hls-js.netlify.com/demo and not just on my page
  • The stream has correct Access-Control-Allow-Origin headers (CORS)
  • There are no network errors such as 404s in the browser console when trying to play the stream

Steps to reproduce

  1. Set source to https://stream.mux.com/wTZ023wl001qXWS7l7YM01ACCXXFl00UXWxH.m3u8?default_subtitles_lang=en
  2. Hit play

Expected behavior

Subtitles should be rendered by default, as manifest contains:

#EXT-X-MEDIA:TYPE=SUBTITLES,GROUP-ID="sub1",CHARACTERISTICS="public.accessibility.transcribes-spoken-dialog",NAME="English",AUTOSELECT=YES,DEFAULT=YES,FORCED=NO,LANGUAGE="en",URI="https://manifest-gce-us-east1-production.fastly.mux.com/V8bC4DI0181YS9KmHe01879BnvZnnNr9SBuQOn01KN202t01O6ZjKUboN3g7YAA01JphiM52peeG2z6Yo/subtitles.m3u8?expires=1619100000&signature=NjA4MTgxNjBfZjUyZjlhNDJjY2NhYmIwMDlkMGY5YjY4NjIyOWQ0Y2U5ODNhZmVhYjYyMmJjZWM2MTRlZmFhN2E0Y2MzMjdjOQ=="

Actual behavior

Subtitles are not displayed by default.

Testing on 0.14.16 displays captions by default as expected: https://philcluff.co.uk/players/hls-js-old.html

1.0.1:
Screenshot 2021-04-15 at 15 33 46

0.14.16:

Screenshot 2021-04-15 at 15 34 21
@robwalch robwalch added this to the 1.0.2 milestone Apr 15, 2021
@robwalch robwalch added the Bug label Apr 15, 2021
@robwalch robwalch added this to Top priorities in Release Planning and Backlog via automation Apr 15, 2021
itsjamie added a commit that referenced this issue Apr 15, 2021
@itsjamie
bugfix: DEFAULT=YES on caption tracks was not being respected.
3cc1555 
Reason for this was because the subtitle grouping wasn't populating the
tracks before the findTrackId function was called. So, it was looking
over an empty array on the first invocation of the function.

By moving it, it now has the correct behaviour and the default track is
selected.

Closes #3780.
@itsjamie itsjamie mentioned this issue Apr 15, 2021
Merged
3 tasks
@robwalch robwalch added the Regression A bug introduced in a recent release label Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Regression A bug introduced in a recent release
Projects
HLS.js Release Planning and Backlog
Archived in project
Release Planning and Backlog
  
Top priorities
Milestone
1.0.2
Development

Successfully merging a pull request may close this issue.

bugfix: DEFAULT=YES on caption tracks was not being respected. video-dev/hls.js
2 participants
@robwalch @philcluff