bugfix: DEFAULT=YES on caption tracks was not being respected. #3781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason for this was because the subtitle grouping wasn't populating the tracks before the findTrackId function was called. So, it was looking over an empty array on the first invocation of the function. By moving it, it now has the correct behaviour and the default track is selected. Closes #3780.
robwalch
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Ensure that the default track is selected after playback.
Why is this Pull Request needed?
Subtitle groups were not respected prior to v1, and now that they are, there was just this tiny gap in the implementation.
By moving when the tracks in the group are populated, the functions work as intended, selecting the default track.
Are there any points in the code the reviewer needs to double check?
Impact analysis on the change.
Resolves issues:
Closes #3780
Checklist