Fix AES-128 in streams with alt-audio tracks #3782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Fix a regression in AES key loading that causes the main and audio stream controllers to load each others' fragments on KEY_LOADED.
Why is this Pull Request needed?
Prior to v1.0,
onKeyLoadedwould set the stream controllers' state to IDLE (even if it was the other controller/level/track fragment's key that was loaded), but this wasn't a show stopper (at worst I guess it would result in keys being requested more than once).In v1.0 the fragment is requested as soon as the key is loaded and parsed, rather than waiting for the next tick. This was done in an effort to improve the performance of AES streams. Our test samples do not include an encrypted stream with separate tracks like the one found in #3772 so this one slipped through.
Resolves issues:
Fixes #3772
Checklist