Request LL-HLS playlists with _HLS_part param starting at 0 for next sn #3784
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
_HLS_part
param set to0
and_HLS_msn
incremented when the last sn matches the segment of the last part.Why is this Pull Request needed?
The current implementation always requests the last part index + 1, which depends on servers responding with part 0 as per this entry in https://tools.ietf.org/html/draft-pantos-hls-rfc8216bis-08#section-4.4.6.2
The downside is that also results in additional caching on the edge since you could have requests for something like
_HLS_msn=1&_HLS_part=4
which must return the same thing as_HLS_msn=2&_HLS_part=0
. By detecting that the last part and last segment match, we know there are no more parts for the current sn, and can increment sn and reset _HLS_part to 0 resolving #3571 and #3771.Resolves issues:
Resolves #3571 #3771
Checklist