Direct set SearchParams on URL and remove sort. #3787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
SearchParamsdirectly onURLinstead of set tourl.search.SearChParams.Why is this Pull Request needed?
Through set
url.searchto add SearchParams that will cause the url isn't equal origin url even if doesn't have any parameter set to. I think theurl.toString()will do encode and server side check the url by string type not equal origin url, so response 403 forbidden.Are there any points in the code the reviewer needs to double check?
Please help to check my thoughts correctly.
Resolves issues:
#3786