Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fetch loader stats marked as aborted after loaded #3801

Merged
merged 1 commit into from Apr 20, 2021

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Apr 19, 2021

This PR will...

Fix fetch loader stats marked as aborted after loaded

Why is this Pull Request needed?

Loader instances are destroyed after each use. The fetch loader was flipping on an aborted flag when destroyed even when complete.

Resolves issues:

Fixes #3789

Checklist

  • changes have been done against master branch, and PR does not conflict

@robwalch robwalch added this to the 1.0.2 milestone Apr 19, 2021
@robwalch robwalch linked an issue Apr 19, 2021 that may be closed by this pull request
@robwalch robwalch merged commit c35441b into master Apr 20, 2021
@robwalch robwalch deleted the bugfix/fetch-loader-aborted-status branch April 20, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

abr-controller stops sampling throughput at download boundaries
1 participant