Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require redundant levels to have matching RESOLUTION and CODECS attributes #3889

Merged

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented May 12, 2021

This PR will...

Use RESOLUTION and CODECS attributes in addition to BANDWIDTH to group levels (STREAM-INF variants) for redundant fallback.

Why is this Pull Request needed?

A stream might have two variants with the same RESOLUTION and BANDWIDTH, but alternative CODECS (like HEVC and H.264) not intended for redundant fallback.

Resolves issues:

Resolves #3888

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)

@MarcusWichelmann
Copy link

MarcusWichelmann commented May 12, 2021

Just tried it and it works perfectly fine now. So I can confirm that this PR fixes #3888.
Much thanks!

@robwalch robwalch merged commit 847ba56 into master May 14, 2021
@robwalch robwalch deleted the feature/redundant-levels-with-resolution-and-codecs branch May 14, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Level controller does not select playable H264 stream when HEVC stream comes first in master playlist
2 participants