Fix audio drift in DAI streams with overlapping AAC samples #3901
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Why is this Pull Request needed?
This mp4-remuxer workaround was disabled in transmuxers for audio-only streams to prioritize segment timing over PTS. This had the side-effect of appending overlapping samples in alt audio-tracks. This is something that happens a lot in certain DAI live streams leading to audio drift.
Are there any points in the code the reviewer needs to double check?
To keep alt-audio in sync with the main stream, these changes pass the playlist type down to the remuxer so that overlapping audio frames are dropped again, preventing audio drift.
Rather than perform the same workaround as before that dropped samples, moving the remixed mp4 start to match the start PTS achieves virtually the same result with less code.
Checklist