Handle AAC overflow with error message #3926
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Store the entire parsed
AudioFrame
and partial sample in tsdemuxeraacOverFlow
. This includes the frame's original PTS, and how many bytes are missing. The remainder is taken from the following AAC PES, added to the sample, and appended to the track. Then that PES's PTS is applied to the following sample.Why is this Pull Request needed?
This avoids the
[tsdemuxer]: AAC: align PTS for overlapping frames by N
warning logs that were really not needed because all this was saying was that we should be usingaacLastPTS
rather than the current PTS for the samples following the remainder of the ACC overflow bytes.Overflowing samples are only parsed and allocated once, so PES data remains constant resulting in less memory allocation.
Resolves issues:
Resolves #3920
Checklist