Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle AAC overflow with error message #3926

Merged
merged 1 commit into from May 22, 2021
Merged

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented May 22, 2021

This PR will...

Store the entire parsed AudioFrame and partial sample in tsdemuxer aacOverFlow. This includes the frame's original PTS, and how many bytes are missing. The remainder is taken from the following AAC PES, added to the sample, and appended to the track. Then that PES's PTS is applied to the following sample.

Why is this Pull Request needed?

This avoids the [tsdemuxer]: AAC: align PTS for overlapping frames by N warning logs that were really not needed because all this was saying was that we should be using aacLastPTS rather than the current PTS for the samples following the remainder of the ACC overflow bytes.

Overflowing samples are only parsed and allocated once, so PES data remains constant resulting in less memory allocation.

Resolves issues:

Resolves #3920

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)

@robwalch robwalch force-pushed the enhancement/aac-overflow-pts branch 2 times, most recently from b8533fe to 681548d Compare May 22, 2021 02:14
@robwalch robwalch added this to In progress in Performance via automation May 22, 2021
@robwalch robwalch added this to the 1.0.5 milestone May 22, 2021
@robwalch robwalch force-pushed the enhancement/aac-overflow-pts branch from 681548d to 5ac472a Compare May 22, 2021 02:17
@robwalch robwalch merged commit 16efcbe into master May 22, 2021
Performance automation moved this from In progress to Done May 22, 2021
@robwalch robwalch deleted the enhancement/aac-overflow-pts branch May 22, 2021 20:39
robwalch pushed a commit that referenced this pull request Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

How common is [log] > [tsdemuxer]: AAC: align PTS for overlapping frames by -23?
1 participant