Fix incorrect audio track segments loaded before video segment with > 0 startPosition #3951
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Use
startPosition
to determine if audio-stream-controller waiting fragment should be cleared.Why is this Pull Request needed?
While waiting for init PTS from the stream-controller's first video segment, the audio-stream-controller will prefetch a segment, and then on tick, check if that
waitingFragment
is correct for the current loading context. If not it is cleared so that it can prefetch a better match.The logic for this used the initial
video.currentTime
of0
which doesn't matchstartPosition
. The player only seeks after media has been buffered to avoid multiple seeks or stalls so it's important that this check usethis.getLoadPosition()
instead. That waystartPosition
is honored until media is buffered andvideo.currentTime
has been adjusted to start playback at the start position.Resolves issues:
Fixes #3950
Checklist