Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix last segment in live removed "context changed" error #3965

Merged
merged 1 commit into from May 28, 2021

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented May 28, 2021

This PR will...

Fix "The loading context changed while buffering fragment" in live streams loading removed fragment

Why is this Pull Request needed?

When the transmuxer completes work on a segment, the stream controller looks for the fragment with a matching sn matching the transmuxer's context. If the fragment was removed from the live sliding window, the fragment was not found and the media would not be appended.

Instead, use the stream controller's fragCurrent in this case to complete buffering of the fragment.

Relates to issues:

#3913

Checklist

  • changes have been done against master branch, and PR does not conflict

@robwalch robwalch added this to the 1.0.5 milestone May 28, 2021
@robwalch robwalch force-pushed the bugfix/live-removed-fragment-context branch from 3757fa8 to 466fbad Compare May 28, 2021 19:21
@robwalch robwalch merged commit 90321c4 into master May 28, 2021
@robwalch robwalch deleted the bugfix/live-removed-fragment-context branch May 28, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant