Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace live playlist sliding warnings with improved logging #3967

Merged
merged 1 commit into from May 29, 2021

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented May 28, 2021

This PR will...

Cleanup alignPlaylists in base-stream-controller. This makes it clear why alignStream is being called. Logging is only performed after a call to alignStream with pertinent information.

Why is this Pull Request needed?

Warnings were being logged on stream start that did not merit that level of logging. The three different logger messages were not always very helpful or informative.

With these changes we'll only see logs when:

  1. There are not fragments (this does merit a warning if an error hasn't already occurred)
  2. Action was taken to align the stream after a refresh or first switch to a new level

Resolves issues:

Resolves #3933

Checklist

  • changes have been done against master branch, and PR does not conflict

@robwalch robwalch added this to the 1.0.5 milestone May 28, 2021
@robwalch robwalch merged commit 35bc1d7 into master May 29, 2021
@robwalch robwalch deleted the task/live-playlist-sliding-logs branch May 29, 2021 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frequent warnings on playback start
1 participant