Remove subtitle cues and data with the back-buffer #3969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
force-pushed
the
enhancement/remove-subtitle-cues-from-back-buffer
branch
2 times, most recently
from
6b15612
to
807552d
Compare
… the fragment-tracker
robwalch
force-pushed
the
enhancement/remove-subtitle-cues-from-back-buffer
branch
from
807552d
to
935e5d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Why is this Pull Request needed?
Longform VOD and live streams with VTT or IMSC1 subtitles should have data and cues cleared with the back-buffer to free up memory. The fragment-tracker was particularly leaky with memory as the loaded data was being added and never removed for each subtitle fragment loaded.
Checklist