Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align live WebVTT subtitle playlists with main playlist #3993

Merged
merged 6 commits into from Jun 4, 2021
Merged

Align live WebVTT subtitle playlists with main playlist #3993

merged 6 commits into from Jun 4, 2021

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Jun 3, 2021 •
edited

This PR will...

  • Align live WebVTT subtitle playlists with main variant using playlist start when program-date-time is unavailable
  • Fix a regression in v1.0.5 where a subtitle track is enabled after back-buffer removal sets a track's mode to "hidden"
  • Update audio-stream alignment with main to be simpler. Both subtitle and audio live playlists will wait for main before being aligned and loading fragments
  • Subtitle playlists will be realigned with main if they get into a state where a loading fragment candidate cannot be found

Why is this Pull Request needed?

Subtitle tracks should be aligned when enabled with the main playlist based on Program-Date-Time when available. Otherwise, aligning on SN may work as is the case with the test stream in #3987

Resolves issues:

Resolves #3987

Checklist

  • changes have been done against master branch, and PR does not conflict

Align live WebVTT subtitle playlists with main variant using media-se…
5e8468a 
…quence when program-date-time is unavailable

Resolves #3987
@robwalch robwalch added this to the 1.0.6 milestone Jun 3, 2021
@robwalch robwalch mentioned this pull request Jun 3, 2021
Closed
5 tasks
@robwalch robwalch force-pushed the feature/sync-live-subtitle-tracks-to-main-msn branch from d7e26ec to 2e3c3ef Compare June 4, 2021 16:28
@robwalch robwalch merged commit 316b99d into master Jun 4, 2021
@robwalch robwalch deleted the feature/sync-live-subtitle-tracks-to-main-msn branch June 4, 2021 17:41
robwalch pushed a commit that referenced this pull request Jun 8, 2021
Fix regression introduced in v1.0.6 (#3993) where subtitle track segm…
bf62d14 
…ent loading at position less than target duration only loads the first segment

(only appears in streams with irregularly large target durations compared to segment duration)
@robwalch robwalch mentioned this pull request Jun 8, 2021
Merged
3 tasks
robwalch pushed a commit that referenced this pull request Jun 8, 2021
Fix regression introduced in v1.0.6 (#3993) where subtitle track segm…
120e098 
…ent loading at position less than target duration only loads the first segment

(only appears in streams with irregularly large target durations compared to segment duration)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.6
Development

Successfully merging this pull request may close these issues.

Captions/subtitles can be slow to appear in live playlist
1 participant
@robwalch