Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mid-stream insertion of missing AAC audio frames #3997

Merged
merged 1 commit into from Jun 4, 2021

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Jun 3, 2021

This PR will...

Fix mid-stream insertion of missing AAC audio frames

Why is this Pull Request needed?

TS streams with missing AAC samples ended up with bad sample times after frames were inserted after 74ac100. This happened when earlier samples were pushed forward more than a sample duration, and the remaining samples were not retimed properly.

Resolves issues:

Resolves #3976

Checklist

  • changes have been done against master branch, and PR does not conflict

@robwalch robwalch added this to the 1.0.6 milestone Jun 3, 2021
@robwalch robwalch merged commit 1e749eb into master Jun 4, 2021
@robwalch robwalch deleted the bugfix/aac-frame-insertion branch June 4, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hls.js displays wrong duration in the video player
1 participant