Fix subtitle segment loading with current time less than target-duration #4023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
changed the title
…ent loading at position less than target duration only loads the first segment (only appears in streams with irregularly large target durations compared to segment duration)
robwalch
force-pushed
the
bugfix/subtitle-start-pos
branch
from
bf62d14
to
120e098
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Fix regression introduced in v1.0.6 with #3993 where subtitle track segment loading at a position less than target duration only loads the first segment.
(only appears in streams with irregularly large target durations compared to segment duration)
Why is this Pull Request needed?
The position argument passed to
bufferedInfoshould never be less than 0 as that is almost certain to not intersect with any buffered time range. subtitle-stream-controller passes in the current time - target duration so that it loads all subtitles at and adjacent to the current time. That resulted in negative values being passes to our buffer util which resulted in misses getting the end of the subtitle stream buffer.Checklist