Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Release Drafter to project workflows #4024

Merged
merged 1 commit into from Jun 8, 2021
Merged

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Jun 8, 2021

This PR will...

Use https://github.com/release-drafter/release-drafter to generate draft release notes for project releases.

@robwalch robwalch requested a review from tjenkinson June 8, 2021 20:06
@robwalch robwalch merged commit 17f4bf2 into master Jun 8, 2021
@robwalch robwalch deleted the task/release-drafter branch June 8, 2021 20:17
@tjenkinson
Copy link
Member

Neat. I think a bit more work is needed though to get the build files uploaded to this release too in the build workflow though

@tjenkinson
Copy link
Member

tjenkinson commented Jun 8, 2021

I think we could move the ‘push’ part to the build workflow and then it returns the upload_url that the other action needs to upload the assets. It could also update the tag to the proper version

@robwalch
Copy link
Collaborator Author

robwalch commented Jun 8, 2021

Thanks!

I merged this in a hurry to see what I could get when cutting v1.0.7. It did create an additional draft release that I deleted. The templated release notes were in there and in the v1.0.7 tag draft that I ultimately published.

@robwalch robwalch added this to the 1.0.7 milestone Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants