Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cue id for date-range cues #5169

Merged
merged 1 commit into from Jan 18, 2023
Merged

add cue id for date-range cues #5169

merged 1 commit into from Jan 18, 2023

Conversation

yajin2021
Copy link
Contributor

This PR will...

Add cue id for date-range cues

Why is this Pull Request needed?

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

robwalch
robwalch approved these changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@robwalch robwalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assigning a value to cue.id was omitted to match the cues produces by Safari when playing HLS without MSE (src="...m3u8"). I don't have any objection to adding it.

@robwalch robwalch added this to the 1.4.0 milestone Jan 18, 2023
@robwalch robwalch merged commit b644288 into video-dev:master Jan 18, 2023
robwalch pushed a commit that referenced this pull request Jan 26, 2023
@yajin2021 @robwalch
add cue id for date-range cues (#5169)
dfa5f54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robwalch robwalch robwalch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yajin2021 @robwalch