fix Netlify redirects #5177
Merged
fix Netlify redirects #5177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjenkinson
force-pushed
the
fix-netlify-redirects
branch
from
2230d47
to
e86af6f
Compare
robwalch
approved these changes
Jan 21, 2023
robwalch
pushed a commit
that referenced
this pull request
Jan 26, 2023
* fix Netlify redirects * remove api docs redirect * Revert "remove api docs redirect" This reverts commit e86af6f. * remove the index file from api docs * also redirect index.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Fix Netlify root redirect. The problem was the second line to setup the api-docs redirect was replacing the file contents instead of appending (
>>).Second reason it wasn't working is because netlify won't redirect by default if a file already exists, so now we delete the index file.
Why is this Pull Request needed?
New commit deployments and https://hls-js-dev.netlify.com/ go to a 404 at the root and api docs redirect doesn’t work