Handle misaligned variant timestamps #5235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
force-pushed
the
bugfix/handle-misaligned-basetime
branch
from
440ad8c
to
6be4c4c
Compare
This was referenced May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Update base timestamp offset (initPTS) when timescale changes or new base time would cause variant timing to be unplayable or not aligned with other assets.
Why is this Pull Request needed?
HLS Authors have trouble packaging HLS assets that share the same base timestamp across variants when the segment types do not match (TS and fmp4).
Are there any points in the code the reviewer needs to double check?
Based on changes that add timescale tracking in feature/content-steering
Resolves issues:
Fixes #5195