Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use optional chaining operator in more places #5243

Merged
merged 2 commits into from Feb 19, 2023
Merged

Conversation

tjenkinson
Copy link
Member

This PR will...

Use optional chaining operator in more places.

cc @itsjamie as looks like you added this rule

Why is this Pull Request needed?

To unblock #5039 which updates eslint, which has made the @typescript-eslint/prefer-optional-chain rule more sensitive.

Copy link
Collaborator

@itsjamie itsjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Passes functional tests.

The only potential for issue would be if one of these values was relying on them being falsy, but not undefined or null.

@tjenkinson tjenkinson merged commit fb959bd into master Feb 19, 2023
@tjenkinson tjenkinson deleted the use-optional-chain branch February 19, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants