Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup config on destroy #5279

Merged
merged 1 commit into from Mar 8, 2023
Merged

Cleanup config on destroy #5279

merged 1 commit into from Mar 8, 2023

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Mar 7, 2023

This PR will...

Cleanup config on destroy /

Are there any points in the code the reviewer needs to double check?

Callbacks can have references to the player instance or other objects in their scope.

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

…player instance or other objects in their scope
@robwalch robwalch added this to the 1.4.0 milestone Mar 7, 2023
@robwalch robwalch merged commit 78db660 into master Mar 8, 2023
@robwalch robwalch deleted the bugfix/memory-config-refs branch March 8, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant