Add ES5 syntax check for UMD builds #5301
Merged
+15,947
−394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
tjenkinson
reviewed
Mar 16, 2023
thornbill
force-pushed
the
add-es5-build-check
branch
from
8c92760
to
7ba1395
Compare
|
Thanks for the review @tjenkinson. I've made the requested changes. I'm not entirely sure why there are so many changes to the package-lock file... it seems most are related to the |
because renovate will keep it updated
tjenkinson
previously approved these changes
Mar 16, 2023
There was a problem hiding this comment.
LGTM! although we can't merge it yet given that the new check correctly fails atm
refs #5299
|
We could wait for #5299 or merge it into there/temp branch for me to rebase that PR. |
robwalch
approved these changes
Mar 16, 2023
|
Merged into working branch. Adding to #5299. |
robwalch
added a commit
that referenced
this pull request
Mar 16, 2023
* task/es5-check: Add ES5 syntax check for UMD builds (#5301)
robwalch
pushed a commit
that referenced
this pull request
Mar 17, 2023
robwalch
added a commit
that referenced
this pull request
Mar 17, 2023
robwalch
added a commit
that referenced
this pull request
Mar 23, 2023
robwalch
added a commit
that referenced
this pull request
Mar 24, 2023
robwalch
added a commit
that referenced
this pull request
Mar 27, 2023
robwalch
added a commit
that referenced
this pull request
Mar 27, 2023
) * Convert build packager to rollup * Add an es module target (#2910) * UMD build worker injection (#5107) * Add ES5 syntax check for UMD builds (#5301, #5288) * Add common rollup config * handle `self` not existing (happens in nodejs. The check that makes sure the dist file can be required in node and not throw was failing because of this.) * Disable coverage in CI * Add `config.workerPath` option and "hls.worker.js" build output (#5107) * Include transmuxer-interface id ("main" and "audio") in Web Worker setup and error logs Co-authored-by: Tom Jenkinson <tom@tjenkinson.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Add a build time check to verify UMD builds are valid ES5 syntax.
Why is this Pull Request needed?
A regression was unknowingly introduced in the v1.2.5 release that caused builds to no longer be compiled to ES5.
This type of check could have caught the issue.
Are there any points in the code the reviewer needs to double check?
This should fail until the build output is corrected.
Resolves issues:
Checklist