Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from netlify to CloudFlare Pages #5305

Merged
merged 5 commits into from Mar 17, 2023
Merged

Switch from netlify to CloudFlare Pages #5305

merged 5 commits into from Mar 17, 2023

Conversation

tjenkinson
Copy link
Member

@tjenkinson tjenkinson commented Mar 17, 2023

This PR will...

Switch from netlify to CloudFlare pages.

Why is this Pull Request needed?

We've been going over the netlify bandwidth limit which costs money, and CloudFlare pages has no bandwidth limit.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Mar 17, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5cf6ebe
Status: ✅  Deploy successful!
Preview URL: https://9dd73fce.hls-js-e5a.pages.dev
Branch Preview URL: https://cf-pages.hls-js-e5a.pages.dev

View logs

@tjenkinson tjenkinson added the CI label Mar 17, 2023
@tjenkinson tjenkinson marked this pull request as ready for review March 17, 2023 13:24
itsjamie

This comment was marked as outdated.

Copy link
Collaborator

@itsjamie itsjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the branch preview is broken that I see in the comment from Cloudflare. Is that something that should be working, or is that expected with this change?

A repo setting and configurable afterwards.

Copy link
Collaborator

@itsjamie itsjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. Once we figure out which account it'll live on, I assume tokens + DNS will change to match wherever. Nice impl and thanks for the crazy turnaround on the swap. 🥇

@tjenkinson
Copy link
Member Author

Once we figure out which account it'll live on, I assume tokens + DNS will change to match wherever

Yeh should just need to generate and then update the token in gh secrets

@tjenkinson tjenkinson merged commit 489e941 into master Mar 17, 2023
@tjenkinson tjenkinson deleted the cf-pages branch March 17, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants