Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fragment from fragment tracker on BUFFER_FULL error and when i… #5354

Conversation

robwalch
Copy link
Collaborator

This PR will...

Remove fragment from fragment tracker:

  1. on BUFFER_FULL error
  2. when fragment is tracked at APPENDING but (audio) stream controller is trying to reload in IDLE state (fragment loading or append was aborted)

Why is this Pull Request needed?

Stream controllers will not reload segments in APPENDING state, however if the controller is trying to load a segment, then it should have exited the parsing and append cycle. Whenever this happens the fragment(s) should be removed from the tracker so that they can be reloaded.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Resolves #5328
Related to #5349 / Follow up to #5350

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

…n appending state and trying to reload on IDLE

Resolves #5328
Related to #5349 / Follow up to #5350
@robwalch robwalch added this to the 1.4.0 milestone Mar 28, 2023
@robwalch robwalch merged commit 4cd93e0 into master Mar 29, 2023
15 of 16 checks passed
@robwalch robwalch deleted the bugfix/clear-fragment-tracker-on-buffer-full-and-idle-appending branch March 29, 2023 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bufferStalled Error on Vimeo HLS Video
1 participant