Content-Steering fix: Keep bit identical subtitle content #5365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robwalch
commented
Apr 1, 2023
robwalch
commented
Apr 1, 2023
robwalch
commented
Apr 1, 2023
|
|
||
| this.tracks.forEach((track, index) => { | ||
| let textTrack: TextTrack | undefined; | ||
| if (index < inUseTracks.length) { | ||
| if (inUseTracks && index < inUseTracks.length) { |
There was a problem hiding this comment.
We can still skip clearCurrentCues below if inUseTracks[i] and track are bit-identical (should be a strict STABLE-RENDITION-ID comparison).
There was a problem hiding this comment.
Deferring to #5371
… tracks are identical Fixes #5361
robwalch
force-pushed
the
bugfix/stable-rendition-subtitle-switching
branch
from
67a28ab
to
6e19b96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Do not clear subtitle cues or tracked fragments when updating subtitle tracks with identical tracks.
Why is this Pull Request needed?
When Content Steering forces a Pathway change, the player updates levels and tracks. Content from matching playlists (where STABLE-RENDITION-ID match) should not be cleared as these playlists are bit-identical.
Are there any points in the code the reviewer needs to double check?
This change also covers tracks with matching attributes. The assumptions is a new list with the exact same languages and characteristics should match the current list for the same Multivariant Playlist.
Resolves issues:
Fixes #5361
Checklist