Skip to content
This repository has been archived by the owner on May 2, 2023. It is now read-only.

alpha/beta flags correctness #48

Open
ThomasPinna opened this issue Sep 15, 2015 · 2 comments
Open

alpha/beta flags correctness #48

ThomasPinna opened this issue Sep 15, 2015 · 2 comments
Labels

Comments

@ThomasPinna
Copy link

$expr = new expression(">1.2.3-beta");
$vers = new version("3.2.5-beta");

$expr->satisfiedBy($vers)

This returns true, but it shouldn't. When a beta flag is given, the user says it is willing to take the risk off instability of this library, but this only counts for this specific version. This means that version("3.2.5") for example should match, but no assumption can be made that the user is willing to take the risk of using the betarelease for this version.

@vierbergenlars
Copy link
Owner

Which version of the library are you using?

@ThomasPinna
Copy link
Author

version 3.0.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants