Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

required options with default value #36

Open
xujif opened this issue Oct 28, 2017 · 2 comments
Open

required options with default value #36

xujif opened this issue Oct 28, 2017 · 2 comments
Assignees
@vilicvane
Labels
feature-request

Comments

@xujif
Copy link

xujif commented Oct 28, 2017

If there is an default value the required shoud not throw an error.
@vilicvane vilicvane self-assigned this Oct 28, 2017
@vilicvane vilicvane added bug and removed bug labels Oct 28, 2017
@vilicvane
Copy link
Owner

@xujif sorry I think I misunderstood your point. Do you mean a param/option with default and is required should not throw an error? If so, why not remove the required property and make it optional as it already has a default value?

@xujif
Copy link
Author

xujif commented Nov 1, 2017

because I wanto set the defaul value with process.env

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vilicvane vilicvane

Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vilicvane @xujif