Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psalm shows minimal output when run via GitHub Actions #10250

Closed
mmcev106 opened this issue Oct 3, 2023 · 4 comments
Closed

Psalm shows minimal output when run via GitHub Actions #10250

mmcev106 opened this issue Oct 3, 2023 · 4 comments

Comments

@mmcev106
Copy link
Collaborator

mmcev106 commented Oct 3, 2023

@ro0NL, version 5.14.0 included commit #8ed4f94 which changed the output format when Psalm is run via GitHub Actions. This broke our unit tests until I tracked it down and unset GITHUB_ACTIONS prior to running our Psalm related tests.

Was this change intended to affect all downstream projects that run Psalm via GitHub Actions? If it was only intended to affect Psalm itself's tests, then I wonder if we should set a new environment variable to control this instead (in Psalm's Github Action configuration).

@psalm-github-bot
Copy link

Hey @mmcev106, can you reproduce the issue on https://psalm.dev ?

@mmcev106
Copy link
Collaborator Author

mmcev106 commented Oct 3, 2023

Nope

@ro0NL
Copy link
Contributor

ro0NL commented Oct 3, 2023

yes, it was intended #9982

you can specify the output format explicitly:

// Ensure CI agnostic output
if (!in_array('--init', $args, true) && !in_array('--alter', $args, true)) {
array_unshift($args, '--output-format=console');
}

i didnt expect downstream would assert it 😹 excusi

(i do think current default behavior is the right one)

@mmcev106
Copy link
Collaborator Author

mmcev106 commented Oct 3, 2023

Thanks for the quick response! Understood, closing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants