Deprecated/not available functions not reported #6935
Labels
Comments
|
I found these snippets: https://psalm.dev/r/5201b68036<?php
each( $array );https://psalm.dev/r/208b2cb781<?php
$array = array( rand( 10, 20 ) => 'bar');
echo array_key_first( $array ); |
|
It appears Psalm reflects the runtime function definition when it can't find the requested function in callmap: |
|
@weirdan I guess there is no way around hardcoding all deprecated/newly introduced functions and just checking against that in psalm? There is a (non-maintained?) tool, that already has all that data collected up to PHP 8.0 (I think PHP 8.0 isn't fully complete, but before that I'm sure it is): https://github.com/wapmorgan/PhpDeprecationDetector/tree/master/data |
|
We have most of that data in callmaps (added and removed functions). If we're going to add deprecations for internal functions, it would make sense to have them there as well. |
kkmuffme
added a commit
to kkmuffme/psalm
that referenced
this issue
Mar 2, 2024
…older than currently used PHP version Fix vimeo#6935
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Assuming psalm.dev runs on PHP 7.4.x (phpVersion=7.4 in config, since I cannot see the actual config)https://psalm.dev/r/5201b68036Should give an error:https://www.php.net/manual/en/migration72.deprecated.php
EDIT: when tested again in 03/2024 with psalm 5.22 this correctly reports
UndefinedFunction=> this is bc since PHP 8.0.0 the function was completely removed, therefore it's reported as "UndefinedFunction". This works correctly as it should, as psalm reports undefined but not only deprecated functions===
Also vice versa, if phpVersion=7.0, I expect to get an error for this:
https://psalm.dev/r/208b2cb781
as the array_key_first function was added in 7.3.0 https://www.php.net/manual/de/function.array-key-first.php
The text was updated successfully, but these errors were encountered: