tidyNode properties’ types are inaccurate

[zopsicle]

The tidyNode class has two properties attribute and child. In Psalm these are both given the type array.

First of all, both properties could have a NULL value. See the example below. Secondly, the types could be more strict, by telling about the array element types.

Proposal

• Make the attribute property of type ?array<string,string>.
• Make the child property of type ?array<tidyNode>.

Example

$tidy = new tidy();
$tidy->parseString('hello');

// $text is of type tidyNode
$text = $tidy->body()->child[0];

assert($text->attribute === NULL);
assert($text->child === NULL);

[psalm-github-bot]

Hey @chloekek, can you reproduce the issue on https://psalm.dev ?

[zopsicle]

I should add: the nullabilities and exact types are unfortunately not documented in the PHP manual for the Tidy extension. I will look into contributing a documentation f ix.

[orklah]

Please provide a PR :)

[othercorey]

@orklah The current property map looks correct

psalm/dictionaries/PropertyMap.php

Line 578 in 2d9e3f4

'attribute' => 'array|null',

[orklah]

yeah, null was added by #8000.

I'll close this, if someone wants to make the extra mile and precise the type inside the array, they're welcome!