Cannot inline suppress UnusedVariable

[still-dreaming-1]

https://psalm.dev/r/25a700869d

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/25a700869d

<?php

/**
 * @psalm-suppress UnusedVariable
 */
$a = 1;

Psalm output (using commit cd002e6):

INFO: UnusedVariable - 6:1 - $a is never referenced or the value is not used

[orklah]

Please check
#5516
#5507
#5493

[AndrolGenhald]

This comes up often enough, could we just support it? Or offer a clear rationale as to why it's not supported in the documentation?

[still-dreaming-1]

Please check
#5516
#5507
#5493

Oops. I know I searched for this before posting here, I guess I accidentally only searched open issues. In the code I work on, I actually did go through and change all truly unused variables that we needed to keep around to $_ before finally trying to just suppress the remaining ones. There is some technical debt in our code we are not ready to deal with that is preventing Psalm from being able to realize the variables are actually used. I think being able to name unused variables as $_ is a great feature, but is different from suppressing it. In the code I'm working on, renaming the variable would break the code since the variables are used. I don't see any reason we should not be able to suppress it like any other issue with an inline suppression annotation. I was able to suppress it into the baseline though, so that is the workaround I am using.

[jpresutti]

I am seriously asking you to support psalm-suppress for this. Expecting us to change our variable names is poor form. Often, coding standards prevent that.

In addition I have open issues right now where it's a false positive. Being able to suppress it until the issues are fixed would make my life a LOT easier.

[theodorejb]

Sometimes a variable is actually used, but a bug in Psalm (e.g. #5700) causes an UnusedVariable error. It would be nice to support psalm-suppress for these, so when the Psalm bug is eventually fixed I will be notified to remove the suppression (as opposed to confusing other developers about why a used variable starts with an underscore).

[mj4444ru]

<?php

$viewName = 'logs';

require __DIR__ . '/view.php';

My example code. I can't suppress the problem.

It would be correct to ignore unused variables when including external scripts.

And it would be even better to tell psalm which variables we plan to transfer to the internal code of the included script.

[M393]

I have a similar problem. bind_param stores a reference to the variable $value and uses it with each execute call, but psalm says it is unused.
https://psalm.dev/r/869a33ad17

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/869a33ad17

<?php

/** @param array<int> $values */
function f(array $values): void {
    $mysqli = new mysqli();
    $stmt = $mysqli->prepare('SELECT ?');
    $stmt->bind_param('i', $value);
    /** @psalm-suppress UnusedForeachValue */
    foreach ($values as $value) {
        $stmt->execute();
    }
}

Psalm output (using commit cd0bacb):

INFO: UnusedForeachValue - 9:25 - $value is never referenced or the value is not used