Feature: psalm-assert "one of" while providing the list of possible values via variable

[boesing]

Hey there,

I think, many of us are using webmozart/assert.
I am experiencing some kind of problem for now, as I cannot tell that a value contains one of the values provided by another value.

Lets assume, I have this piece of code:
https://psalm.dev/r/e5faadd216

I dont know any way to provide psalm-assert informations that the unknownValue is one of these which were provided via the $values argument of Assert::oneOf.

Is that something which could be achieved in any way?

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/e5faadd216

<?php

namespace Webmozart
{
    class Assert
    {
        /**
         * @psalm-pure
         * @throws \InvalidArgumentException
         */
        public static function oneOf(mixed $value, array $values): void
        {
            if (!\in_array($value, $values, true)) {
            	throw new \InvalidArgumentException('whatever');
	        }
        }
    }
}

namespace {
    class Foo
    {
        public const VALUE_FOO = 'foo';
	    public const VALUE_BAR = 'bar';
	    public const VALUE_BAZ = 'baz';

        /** @psalm-param self::VALUE_* $value */
        public static function qoo(string $value): void
        {
            $value;
        }
    }
    
    /** @var string $unknownValue */
    $unknownValue = $_SERVER['QUERY_STRING'] ?? '';
    \Webmozart\Assert::oneOf($unknownValue, [Foo::VALUE_FOO, Foo::VALUE_BAR, Foo::VALUE_BAZ]);
        
    Foo::qoo($unknownValue);
}

Psalm output (using commit 0d524ec):

ERROR: ArgumentTypeCoercion - 38:14 - Argument 1 of Foo::qoo expects "bar"|"baz"|"foo", parent type string provided

[weirdan]

I would expect something like this to work: https://psalm.dev/r/13845d6d06 (but it doesn't)

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/13845d6d06

<?php

namespace Webmozart {
    class Assert {
        /**
         * @psalm-pure
         * @template T
         * @param array<array-key, T> $values
         * @psalm-assert T $value
         *
         * @throws \InvalidArgumentException
         */
        public static function oneOf(mixed $value, array $values): void {
            if (!\in_array($value, $values, true)) {
            	throw new \InvalidArgumentException('whatever');
	        }
        }
    }
}

namespace {
    /**
     * @return 'a'|'b' 
     */
    function f(string $unknownValue): string {
        \Webmozart\Assert::oneOf($unknownValue, ['a', 'b']);
    	/** @psalm-trace $unknownValue */;
        return $unknownValue;
    }
}

Psalm output (using commit 0d524ec):

INFO: Trace - 27:39 - $unknownValue: string

INFO: LessSpecificReturnStatement - 28:16 - The type 'string' is more general than the declared return type '"a"|"b"' for f

INFO: MoreSpecificReturnType - 23:16 - The declared return type '"a"|"b"' for f is more specific than the inferred return type 'string'

[boesing]

Closed with #8077