False positive UnusedVariable when wrapping catched exception

[discordier]

When an exception is catched and overridden in the catch block, psalm thinks the variable is unused (might be related to #5700).

https://psalm.dev/r/24f4faa0bd

To make the issue even worse, this can NOT be supressed:
https://psalm.dev/r/9b5d2bd80c

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/24f4faa0bd

<?php

function test(): void
{
    try {
	    return;
	} catch (\RuntimeException $exception) {
	    $exception = new \LogicException('test', 0, $exception);
	} catch (Throwable $exception) {
	    $exception = new \InvalidArgumentException('test 2', 0, $exception);
	}

    echo $exception->getMessage();
}

Psalm output (using commit e17290a):

INFO: UnusedVariable - 8:6 - $exception is never referenced or the value is not used

https://psalm.dev/r/9b5d2bd80c

<?php

function test(): void
{
    try {
	    return;
	} catch (\RuntimeException $exception) {
        /** @psalm-suppress UnusedVariable */
	    $exception = new \LogicException('test', 0, $exception);
	} catch (Throwable $exception) {
	    $exception = new \InvalidArgumentException('test 2', 0, $exception);
	}

    echo $exception->getMessage();
}

Psalm output (using commit e17290a):

INFO: UnusedVariable - 9:6 - $exception is never referenced or the value is not used

[orklah]

@AndrolGenhald do you think this is fixed too?

[AndrolGenhald]

Probably not, I might take a look at it tomorrow though (or at least this week, time does tend to get away from me...).

[orklah]

Cool! Just in case some may be similar, we have a few other issue related to try/catch control flow
#6286
#5973
#5967
#5700
#4889