Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webmozart/path-util is abandoned - use symfony/filesystem instead #6883

Closed
garrettw opened this issue Nov 10, 2021 · 11 comments
Closed

webmozart/path-util is abandoned - use symfony/filesystem instead #6883

garrettw opened this issue Nov 10, 2021 · 11 comments
Milestone

Comments

@garrettw
Copy link

Just installed the latest version of psalm and was surprised to see an abandoned package warning:

Package webmozart/path-util is abandoned, you should avoid using it. Use symfony/filesystem instead.

"webmozart/path-util": "^2.3"

@psalm-github-bot
Copy link

Hey @garrettw, can you reproduce the issue on https://psalm.dev ?

@weirdan
Copy link
Collaborator

weirdan commented Nov 10, 2021

Not going to happen until we drop PHP 7.1 support, as symfony/filesystem:5.4 (where webmozart/path-util was merged) is not compatible with 7.1. Besides, there were no stable releases in 5.4 branch yet.

@weirdan weirdan closed this as completed Nov 10, 2021
@Dgame
Copy link
Contributor

Dgame commented Nov 11, 2021

Not going to happen until we drop PHP 7.1 support, as symfony/filesystem:5.4 (where webmozart/path-util was merged) is not compatible with 7.1. Besides, there were no stable releases in 5.4 branch yet.

Do you have any idea when this will happen? PHP 7.1 and 7.2 have already reached EOL in 2019 / 2020.

@orklah
Copy link
Collaborator

orklah commented Nov 11, 2021

We still have to figure this out for the next major release of Psalm.

Psalm 4 was scheduled to drop 7.1 and 7.2 but after user feedback and seeing we didn't use features from those versions, it was reverted back.

Static analysis is a tough tool to upgrade because user kinda expect to analyse their code with the same version they have in production...

@weirdan
Copy link
Collaborator

weirdan commented Nov 11, 2021

because user kinda expect to analyse their code with the same version they have in production...

even though Psalm is mostly able to analyze code targeting older PHP runtime even when it runs on a modern one.

@weirdan
Copy link
Collaborator

weirdan commented Nov 11, 2021

Psalm 4 was scheduled to drop 7.1 and 7.2 but after user feedback and seeing we didn't use features from those versions, it was reverted back.

https://packagist.org/packages/vimeo/psalm/php-stats#4 - currently it's 10% Psalm installations on 7.2 on a bad day.

@jraller
Copy link

jraller commented Dec 13, 2021

https://github.com/symfony/filesystem/releases/tag/v5.4.0 has a stable release and appears to support "php": ">=7.2.5",.

@ricardoboss
Copy link
Contributor

Can you reopen the issue until it is fixed? I feel like this shouldn't be closed...

@weirdan weirdan added this to the Psalm 5 milestone Jan 7, 2022
@weirdan
Copy link
Collaborator

weirdan commented Jan 7, 2022

@ricardoboss This is already fixed in master (future Psalm 5): #7292

@mdeboer
Copy link

mdeboer commented Jan 12, 2022

I don´t know when Psalm 5 is due to be released but judging by the PR, this could very easily be backported to Psalm 4 right?

@orklah
Copy link
Collaborator

orklah commented Jan 12, 2022

Unfortunately no, because Psalm 4 support PHP 7.1 and symfony/filesystem does not as explained above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants