PHP_INT_MAX isn't positive-int, but int

[kelunik]

https://psalm.dev/r/6c3860181f

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/6c3860181f

<?php

usleep(PHP_INT_MAX);

Psalm output (using commit 9943efb):

ERROR: ArgumentTypeCoercion - 3:8 - Argument 1 of usleep expects 0|positive-int, parent type int provided

[kelunik]

See

psalm/src/Psalm/Internal/Analyzer/Statements/Expression/Fetch/ConstFetchAnalyzer.php

Lines 167 to 173 in 6f1d438

	case 'PHP_INT_MAX':
	case 'PHP_INT_MIN':
	case 'PHP_INT_SIZE':
	case 'PHP_MAXPATHLEN':
	case 'PHP_VERSION_ID':
	case 'PHP_ZTS':
	return Type::getInt();

.

[orklah]

Good catch. Care to provide a PR?

(I'm really curious about the use case if this is a legit piece of code :D)

[kkmuffme]

(I'm really curious about the use case if this is a legit piece of code :D)

It's probably not, but (u)sleep is the most convenient function to reproduce psalm false positives with positive-int/int type, see #6966 :)

[kelunik]

It's a legit piece of code, yeah: revoltphp/event-loop@dc9fbe7

[ricardoboss]

I opened a PR that may fix this: #7070