Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename was_static property to is_static to be more accurate #7358

Merged
merged 1 commit into from Jan 9, 2022

Conversation

muglug
Copy link
Collaborator

@muglug muglug commented Jan 9, 2022

Using "was" here doesn't make much sense, because the type being analysed is static aka this.

@muglug muglug added the release:internal The PR will be included in 'Internal changes' section of the release notes label Jan 9, 2022
@orklah
Copy link
Collaborator

orklah commented Jan 9, 2022

Great! I remember wondering if there was a meaning behind "was"! Thanks!

@orklah orklah merged commit e1e3839 into master Jan 9, 2022
@muglug muglug deleted the muglug-what-was-is-is branch January 9, 2022 20:14
@weirdan weirdan restored the muglug-what-was-is-is branch January 9, 2022 20:34
weirdan added a commit to weirdan/psalm that referenced this pull request Jan 9, 2022
@muglug muglug deleted the muglug-what-was-is-is branch January 15, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:internal The PR will be included in 'Internal changes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants