False positive: RedundantCondition - $foo is not in-array-Foo has already been asserted

[BenMorel]

Checking in_array() twice on two different arrays produces a wrong RedundantCondition error:

class User {}

interface UserRepository {
    /**
     * @return User[]
     */
    public function findBy(array $criteria): array;
}

function test(User $user, UserRepository $userRepository): void {
    $a = $userRepository->findBy(['foo' => 1]);
    $b = $userRepository->findBy(['bar' => 2]);

    if (!in_array($user, $a, true) && !in_array($user, $b, true)) {
        throw new Exception();
    }
}

ERROR: RedundantCondition - 16:9 - $user is not in-array-User has already been asserted

https://psalm.dev/r/6d5c4d5b60

Notes:

• using a single !in_array() works fine
• using in_array() without strict: true works fine

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/6d5c4d5b60

<?php

class User {}

interface UserRepository {
    /**
     * @return User[]
     */
    public function findBy(array $criteria): array;
}

function test(User $user, UserRepository $userRepository): void {
    $a = $userRepository->findBy(['foo' => 1]);
    $b = $userRepository->findBy(['bar' => 2]);

    if (!in_array($user, $a, true) && !in_array($user, $b, true)) {
        throw new Exception();
    }
}

Psalm output (using commit e1d2da7):

ERROR: RedundantCondition - 16:9 - $user is not in-array-User has already been asserted

[orklah]

has already been asserted errors should probably be disabled on in-array- assertions.

It's useful to know for example that $a is in an array that contains only strings (because we can infer $a is a string). However, checking that it's in another array containing other strings is not redundant

[orklah]

This error is handled in AlgebraAnalyzer, which is a pretty generic piece of code except for this ugly thing:

psalm/src/Psalm/Internal/Analyzer/AlgebraAnalyzer.php

Line 138 in 97e6511

if (preg_match('@^!?in-array-@', $possibility)) {

I really want to wait for #7410 to fix that properly... I'll see